| Age | Commit message (Collapse) | Author |
|
https://github.com/ocaml/opam-repository/pull/13118#pullrequestreview-183576751
Suggested-By: @mseri on Github
|
|
Ugh, experiments show that MS will parse arbitrarily short hex encoded
IAs which in turn revealed miscalculation in our sloppy parsing mode.
|
|
Increment major version due to API breakage.
|
|
In MS mode we need for much shorter strings to pass through to the
hex parser.
|
|
|
|
Provide immediate feedback on stdout when running in an interactive
terminal the assumption being we’re dealing with a human.
|
|
Add a conformance handler “Con_MS” to achieve a behavior that
mimicks that of MS’s implementation bug-for-bug.
Aspects of reading and formatting governd by the conformance:
- Validation of ident auths,
- validation of subauths,
- validation of leading zeros in decimal numbers,
- zero-padding of hex numbers.
|
|
Offload the test for member count and size constraints of sas and ia,
respectively, into a separate validation module. This is a preparatory
step toward adding less rigid parsing modes.
|
|
|
|
Both the constructor “Sid.create” and the string format parser must
reject inputs lacking a subauthorities array of at least size one. Since
the array is no longer optional, reorder the the constructor arguments
to match the data representation.
It is still possible to create SIDs without subauthorities via the
“Sid.create_unsafe” constructor. Also, the packet representation will
happily accept them because their definition (as well as that that of
the identical RPC version) does not specify a minimum count.
This is all rather ambiguous and exacerbated by the fact that [MS-DTYP]
happily specifies an invalid SID “S-1-5” as the “NT_AUTHORITY”. However,
both the grammar and the Win API “ConvertStringSidToSidA()” function
reject SA-less inputs as invalid, so we should too.
|
|
In string format, the “identifier authority” is quirky: from 1 << 32 on
the spec requires that exactly 12 hex digits be printed.
|
|
Establish symmetry with of_string / to_string and the StringFmt module.
|
|
Apparently, the “result” type was not introduced until after the 4.02
series.
Suggested-By: @kit-ty-kate on github
|
|
Reject ia’s greater than six bytes can encompass.
|
|
This change reflects:
https://github.com/ocaml/opam-repository/pull/12935/commits/5d761aa7bc982d40514787c8340b00374dbf1f0b
Suggested-By: @kit-ty-kate on github
|
|
|
|
- Add cmdliner to deps,
- set {with-test} filter on unit tests,
- version 1 → 1.1.
|
|
Also set minimum compiler version to 4.02 for package since that’s when
the bytes type was introduced.
|
|
|
|
|
|
Add the constants from MS-DTYP 2.4.2.4 to Sid.WellKnown.
|
|
|
|
|
|
|
|
|
|
|
|
In the string representation, hyphen is always succeeded by a number
so we need to terminate at input length minus one.
|
|
|
|
Get rid of all “StringFmt” APIs involving exceptions.
There is now only the “decode” function which returns
a result type.
|
|
|
|
|
|
|
|
Oddly enough this only has an effect on the sub_auths since the 48 bits
of “identifier authority” are always handled in big endian.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|